8000 KEP 4960: Container Stop Signals by sreeram-venkitesh · Pull Request #130556 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

KEP 4960: Container Stop Signals #130556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 24, 2025
Merged

KEP 4960: Container Stop Signals #130556

merged 7 commits into from
Mar 24, 2025

Conversation

sreeram-venkitesh
Copy link
Member

What type of PR is this?

/kind feature
/kind api-change
/sig node

What this PR does / why we need it:

This PR includes the implementation for the alpha realease of kubernetes/enhancements#4960. We're adding a new Container Lifecycle, StopSignal, with which users can configure custom stop signals for their containers. This involves changes to the CRI API as well.

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#4960

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added support for configuring custom stop signals with a new StopSignal container lifecycle

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- KEP: https://github.com/kubernetes/enhancements/issues/4960

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from dims and liggitt March 4, 2025 11:50
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Mar 4, 2025
Open
15 tasks
@bart0sh bart0sh moved this from Triage to Work in progress in SIG Node: code and documentation PRs Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Mar 5, 2025
@mrunalp
Copy link
Contributor
mrunalp commented Mar 11, 2025

@sreeram-venkitesh Could you move this from draft? Reviewers won't typically look at it if it is in draft.

@sreeram-venkitesh sreeram-venkitesh marked this pull request as ready for review March 11, 2025 17:23
@sreeram-venkitesh
Copy link
Member Author

There are a bunch of tests which will fail now. I had kept the PR in draft until the tests were fixed. I will push the test fixes later today.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sreeram-venkitesh, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrunalp
mrunalp reviewed Mar 24, 2025
View reviewed changes
staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto
message Lifecycle {
// The custom stop signal for the container
Signal stop_signal = 1;
Signal stop_signal = 18;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you merge this into the commit introducing the CRI change so the commit history is clean?

mrunalp
mrunalp reviewed Mar 24, 2025
View reviewed changes
staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto
SIGWINCH = 32;
SIGXCPU = 33;
SIGXFSZ = 34;
SIGALRM = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we move this entire commit to where CRI api changes are first introduced?

@sreeram-venkitesh sreeram-venkitesh force-pushed the kep-4960-container-stop-signals branch from d78cbf4 to 52c3010 Compare March 24, 2025 20:37
@haircommander
Copy link
Contributor

/lgtm

great work @sreeram-venkitesh !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ad4fef30b05678d768c0bf7ec53c93d4fb0f415

@haircommander
Copy link
Contributor
haircommander commented Mar 24, 2025 •
edited
Loading

/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 24, 2025
@sreeram-venkitesh
Copy link
Member Author

The test failure seems to be unrelated. Will try retesting once all the checks are completed.

@sreeram-venkitesh
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor
k8s-ci-robot commented Mar 24, 2025 •
edited
Loading

@sreeram-venkitesh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-crio-cgrpv1-dra b211904 link false /test pull-kubernetes-node-e2e-crio-cgrpv1-dra
pull-kubernetes-kind-dra b211904 link false /test pull-kubernetes-kind-dra
pull-kubernetes-kind-dra-all b211904 link false /test pull-kubernetes-kind-dra-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sreeram-venkitesh
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit ff25881 into kubernetes:master Mar 24, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Mar 24, 2025
@bitoku bitoku mentioned this pull request Mar 27, 2025
Merged
@mikebrow mikebrow mentioned this pull request Mar 28, 2025
Open
@bitoku bitoku mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

@cici37 cici37 Awaiting requested review from cici37

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@ffromani ffromani Awaiting requested review from ffromani

+5 more reviewers

@mrunalp mrunalp mrunalp left review comments

@haircommander haircommander haircommander left review comments

@mikebrow mikebrow mikebrow left review comments

@toVersus toVersus toVersus left review comments

@HirazawaUi HirazawaUi HirazawaUi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@mrunalp mrunalp

@thockin thockin

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Archived in project
SIG Apps
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
[sig-release] Bug Triage
Archived in project
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
0