8000 Clarify the behavior when the host_port value is set to 0 in CRI by HirazawaUi · Pull Request #130512 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Clarify the behavior when the host_port value is set to 0 in CRI #130512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

Clarify the behavior when the host_port value is set to 0 in CRI #130512

merged 1 commit into from
Mar 1, 2025

Conversation

HirazawaUi
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

ref: #130460 (comment)

Which issue(s) this PR fixes:

Fixes #130460

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 1, 2025
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 1, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 1, 2025
@HirazawaUi
Copy link
Contributor Author

/sig network
/cc @thockin @aojea @mikebrow

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Mar 1, 2025
@aojea
Copy link
Member
aojea commented Mar 1, 2025

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a98b28a899718e1ab9adcfbd6fb9a3705fc0a42

@aojea
Copy link
Member
aojea commented Mar 1, 2025

@HirazawaUi use /assign for the people you require review, and /cc for the one you think may be interested , or people may miss it :)

/assign @mikebrow @thockin

@HirazawaUi
Copy link
Contributor Author

@HirazawaUi use /assign for the people you require review, and /cc for the one you think may be interested , or people may miss it :)

/assign @mikebrow @thockin

Thanks for reminder.

@adrianmoisey
Copy link
Member

/lgtm

@thockin
Copy link
Member
thockin commented Mar 1, 2025

/approve

Given the name of the type, it's unclear if it should even be specified if there is no hostport, but it is what it is now :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit b669e6c into kubernetes:master Mar 1, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 1, 2025
@mikebrow
Copy link
Member
mikebrow commented Mar 3, 2025

LGTM thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@sjenning sjenning Awaiting requested review from sjenning

@aojea aojea Awaiting requested review from aojea

@mikebrow mikebrow Awaiting requested review from mikebrow

@thockin thockin Awaiting requested review from thockin

Assignees

@adrianmoisey adrianmoisey

@thockin thockin

@aojea aojea

@mikebrow mikebrow

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

CRI and networking behavior

6 participants

@HirazawaUi @k8s-ci-robot @aojea @adrianmoisey @thockin @mikebrow
0