8000 [KEP-4639] Graduate image volume sources to beta by saschagrunert · Pull Request #130135 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

[KEP-4639] Graduate image volume sources to beta #130135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

[KEP-4639] Graduate image volume sources to beta #130135

merged 1 commit into from
Mar 13, 2025

Conversation

saschagrunert
Copy link
Member
@saschagrunert saschagrunert commented Feb 13, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduate the feature to beta, by:

  • Allowing subPath/subPathExpr for image volumes
  • Modifying the CRI to pass down the (resolved) sub path
  • Adding outlined metrics

Which issue(s) this PR fixes:

Refers to kubernetes/enhancements#4639

Special notes for your reviewer:

We can add an e2e test for the subpath feature when CRI-O supports it.

Does this PR introduce a user-facing change?

Graduated image volume sources to beta:
  - Allowed `subPath`/`subPathExpr` for image volumes
  - Added kubelet metrics `kubelet_image_volume_requested_total`, `kubelet_image_volume_mounted_succeed_total` and `kubelet_image_volume_mounted_errors_total`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


8000
KEP: https://github.com/kubernetes/enhancements/issues/4639

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2025
@saschagrunert saschagrunert mentioned this pull request Feb 13, 2025
Open
14 tasks
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 13, 2025
@saschagrunert
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 13, 2025
@saschagrunert saschagrunert added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 13, 2025
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2025
@saschagrunert saschagrunert removed the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Feb 13, 2025
@saschagrunert
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Feb 14, 2025
liggitt
liggitt reviewed Feb 28, 2025
View reviewed changes
@saschagrunert
Copy link
Member Author

@liggitt PTAL again :)

@liggitt
Copy link
Member
liggitt commented Mar 5, 2025

/approve
for API changes

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@liggitt liggitt moved this to API review completed, 1.33 in API Reviews Mar 5, 2025
This was referenced Mar 10, 2025
Merged
Merged
@saschagrunert
Copy link
Member Author

@kubernetes/sig-node-pr-reviews PTAL, I still need an LGTM from the SIG

mrunalp
mrunalp reviewed Mar 10, 2025
View reviewed changes
@saschagrunert
Graduate image volume sources to beta
f9e5dd8 
Graduate the feature to beta, by:

- Allowing `subPath`/`subPathExpr` for image volumes
- Modifying the CRI to pass down the (resolved) sub path
- Adding metrics which are outlined in the KEP

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@carlory carlory mentioned this pull request Mar 12, 2025
Closed
@Shubham82 Shubham82 mentioned this pull request Mar 12, 2025
Merged
@saschagrunert saschagrunert linked an issue Mar 12, 2025 that may be closed by this pull request
pull-kubernetes-node-e2e-containerd-alpha-features: ImageVolume/Device Plugin test failed #130669
Closed
mrunalp
mrunalp reviewed Mar 12, 2025
View reviewed changes
test/e2e_node/image_volume.go

secondFileContents := e2epod.ExecCommandInContainer(f, podName, containerName, "/bin/cat", filepath.Join(volumePath, "etc", "os-release"))
gomega.Expect(secondFileContents).To(gomega.ContainSubstring("Alpine Linux"))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I’ll do that in the follow-up!

mrunalp
mrunalp approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor
@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa272f329ccb60fc5cf3261ffd0b8bb01cf5250c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, liggitt, mikebrow, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7b6c56e into kubernetes:master Mar 13, 2025
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 13, 2025
@github-project-automation github-project-automation bot moved this from Archive-it to Done in SIG Node CI/Test Board Mar 13, 2025
@github-project-automation github-project-automation bot moved this from Needs Reviewer to Done in SIG Node: code and documentation PRs Mar 13, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Mar 13, 2025
@saschagrunert saschagrunert deleted the image-volume-beta branch March 13, 2025 07:17
This was referenced Mar 19, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@sallyom sallyom Awaiting requested review from sallyom

@wzshiming wzshiming Awaiting requested review from wzshiming

@carlory carlory Awaiting requested review from carlory

+4 more reviewers

@mikebrow mikebrow mikebrow approved these changes

@mrunalp mrunalp mrunalp approved these changes

@haircommander haircommander haircommander approved these changes

@hashim21223445 hashim21223445 hashim21223445 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mrunalp mrunalp

@liggitt liggitt

@carlory carlory

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.33
SIG Apps
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.

pull-kubernetes-node-e2e-containerd-alpha-features: ImageVolume/Device Plugin test failed
0