cri-api: add mappings for volumes #116249
Conversation
|
/sig node |
|
/triage accepted |
|
LGTM label has been added. Git tree hash: a2ab0931caaba673bdc65cf529d140b6db1c3cce
|
|
/assign v1.27 |
add the definitions for the ID mappings to use at runtime for the volume mount. This is supported only on Linux where idmapped mounts are used to perform the runtime mapping. The new fields are mapped directly to the field in the OCI runtime specs: https://github.com/opencontainers/runtime-spec/blob/main/config.md#posix-platform-mounts The CRI runtime will pass the mappings to the OCI runtime as-is. Related to KEP-127. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
f8bae06 to
c866e09
Compare
|
@giuseppe: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
LGTM label has been added. Git tree hash: b1d996884472b45495e80969c18f843b4fd2a889
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: giuseppe, rata, saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
is it worth keeping this PR open now that we've opened #116377 ? Should I just close it and move all the discussion there? |
|
makes sense. Let's merge alongside the implementation. /close |
|
@SergeyKanzhelev: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
add the definitions for the ID mappings to use at runtime for the volume mount. This is supported only on Linux where idmapped mounts are used to perform the runtime mapping.
The new fields are mapped directly to the field in the OCI runtime specs:
https://github.com/opencontainers/runtime-spec/blob/main/config.md#posix-platform-mounts
The CRI runtime will pass the mappings to the OCI runtime as-is.
Related to KEP-127.
What type of PR is this?
/kind feature
What this PR does / why we need it:
it adds the definitions for the ID mappings to use at runtime for the volume mount. This is supported only on Linux where idmapped mounts are used to perform the runtime mapping.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: