8000 fix checkIsEmptyDir by mcarbonneaux · Pull Request #1978 · kubernetes/kompose · GitHub
[go: up one dir, main page]
Skip to content

fix checkIsEmptyDir #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix checkIsEmptyDir #1978

wants to merge 7 commits into from

Conversation

mcarbonneaux
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix bug in recursive checkIsEmptyDir that not work from 1.33.0...

Which issue(s) this PR fixes:

Fixes #1977

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 18, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Dec 18, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @mcarbonneaux!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 18, 2024
cdrage
cdrage requested changes Dec 19, 2024
View reviewed changes
pkg/transformer/kubernetes/k8sutils.go Outdated
return true, err
}
for _, file := range files {
if !file.IsDir() {
log.Debugf("IsDir of %v return that is not directory !",file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove debug calls and error log calls

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remove it, but some time is usefull to have more information hiden in debug that you can log level up to troubleshoot (by default debug output is not printed...) ...

Sorry, something went wrong.

Copy link
Author
@mcarbonneaux mcarbonneaux Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i've changed warnf to errorf because normaly is not a warn!

@cdrage
Copy link
Member
cdrage commented Dec 19, 2024

gofmt also needs to be called too! Thanks for the contribution @mcarbonneaux

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2024
TessaIO
TessaIO reviewed Dec 20, 2024
View reviewed changes
Copy link
Member
@TessaIO TessaIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, couple of nits

@mcarbonneaux
remove comment
4b0cdad 
change errorf from %v to %s
@TessaIO
Copy link
Member
TessaIO commented Dec 21, 2024

@mcarbonneaux seems like some e2e tests are failing due to your PR. Can you fix them before approving the PR?

@mcarbonneaux
Copy link
Author

i've tryed to fix the test.

@mcarbonneaux
Copy link
Author

any news ?

@cdrage
Copy link
Member
cdrage commented Apr 15, 2025

any news ?

Hi, sorry about the delay.

Can you rebase against master and try again with the tests / see if it works?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mcarbonneaux
Once this PR has been reviewed and has the lgtm label, please assign tessaio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mcarbonneaux mcarbonneaux requested a review from cdrage May 14, 2025 19:35
@mcarbonneaux
Copy link
Author

Can you rebase against master and try again with the tests / see if it works?

i've synced the master, but i don't kown how to launch the test.

@mcarbonneaux
Copy link
Author
mcarbonneaux commented May 14, 2025 •
edited
Loading

i've try make test and i have this error but is seem not related to my commits:

===> Starting test <===
convert::expect_success: Running: 'kompose -f /data/ch2o/k8s/kompose/script/test/fixtures/configmap-file-configs/compose-3.yaml convert --stdout --with-kompose-annotation=false' expected_output: '/data/ch2o/k8s/kompose/script/test/fixtures/configmap-file-configs/output-k8s-3.yaml'
.....
test: "" kind: ConfigMap metadata: labels: io.kompose.service: busy name: busy-cm0 kind: ConfigMap metadata: name: busy-cm0 labels: io.kompose.service: busy spec.template.spec (apps/v1/Deployment/busy) + one map entry added: volumes: - name: busy-cm0 configMap: name: busy-cm0 spec.template.spec.containers.busy (apps/v1/Deployment/busy) + one map entry added: volumeMounts: - name: busy-cm0 mountPath: /tmp readOnly: true
FAIL: converted output does not match
make: *** [Makefile:85: test-cmd] Error 1

the diff of the genereted spec and the espected spec:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TessaIO TessaIO TessaIO left review comments

@cdrage cdrage Awaiting requested review from cdrage

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] WARN Failed to check if the directory is empty: open data: no such file or directory
4 participants
@mcarbonneaux @k8s-ci-robot @cdrage @TessaIO
0