8000 [release-2.0] fix(rbac): Add required RBAC to update ClusterTrainingRuntimes on OpenShift by google-oss-robot · Pull Request #2684 · kubeflow/trainer · GitHub
[go: up one dir, main page]

Skip to content

Conversation

google-oss-robot
Copy link

This is an automated cherry-pick of #2682

/assign andreyvelich

8000
…nShift

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15927432106

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 29.19%

Totals Coverage Status
Change from base Build 15581813519: 0.0%
Covered Lines: 897
Relevant Lines: 3073

💛 - Coveralls

@astefanutti
Copy link
Contributor

/lgtm

Copy link
Member
@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member
@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@astefanutti Could you update Helm Chart as well?

@tenzen-y
Copy link
Member

Oh, this is cherry-pick PR.
/hold cancel

@astefanutti
Copy link
Contributor

@astefanutti Could you update Helm Chart as well?

Let me create a follow up.

@tenzen-y
Copy link
Member

@astefanutti Could you update Helm Chart as well?

Let me create a follow up.

Thank you.

Copy link
Member
@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Electronic-Waste,andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f714c06 into kubeflow:release-2.0 Jun 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0