Revert "fix(sdk): Fix type annotation for train method's trainer parameter"
#2651
Conversation
|
@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: eoinfennessy. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…paramete…" This reverts commit 7b1b39b. Signed-off-by: Electronic-Waste <2690692950@qq.com>
82fa4a4 to
75929d2
Compare
Pull Request Test Coverage Report for Build 15275924720Details
💛 - Coveralls |
|
@eoinfennessy: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Never mind @eoinfennessy! Appreciate your passion to Kubeflow! |
There was a problem hiding this comment.
Thank you for this @Electronic-Waste @eoinfennessy!
As @Electronic-Waste mentioned, once we merge all of the PRs for LLM Trainer, we can support BuiltinTrainer trainer type.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…parameter" (kubeflow/trainer#2651) This reverts commit c926ec0. Signed-off-by: Electronic-Waste <2690692950@qq.com>
…parameter" (kubeflow/trainer#2651) This reverts commit c926ec0. Signed-off-by: Electronic-Waste <2690692950@qq.com>
…parameter" (kubeflow/trainer#2651) This reverts commit c926ec0. Signed-off-by: Electronic-Waste <2690692950@qq.com>
…parameter" (kubeflow/trainer#2651) This reverts commit c926ec0. Signed-off-by: Electronic-Waste <2690692950@qq.com>
…parameter" (kubeflow#2651) This reverts commit 7b1b39b. Signed-off-by: Electronic-Waste <2690692950@qq.com>
Reverts #2646
/cc @eoinfennessy @kubeflow/wg-training-leads @astefanutti