8000 feat: automate releases using script by milinddethe15 · Pull Request #2623 · kubeflow/trainer · GitHub
[go: up one dir, main page]
Skip to content

feat: automate releases using script #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: automate releases using script #2623

wants to merge 3 commits into from

Conversation

milinddethe15
Copy link
Member
@milinddethe15 milinddethe15 commented Apr 29, 2025 •
edited
Loading

What this PR does / why we need it:

  1. This PR adds a release script to generate a releasing commit of vX.Y.Z

Usage to generate for new release:

./hack/release.sh X.Y.Z
  • It updates the VERSION file
  • and, the image tags in manifest to correspond to that particaluar version
  1. Adds a release github action
  • publishes the image with the corresponding version tag

Testing on forked branch: https://github.com/milinddethe15/kf-trainer/tree/release-5.0.0

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2155

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

milinddethe15
milinddethe15 commented Apr 29, 2025
View reviewed changes
@andreyvelich andreyvelich mentioned this pull request May 2, 2025
Merged
1 task
@Electronic-Waste Electronic-Waste mentioned this pull request May 2, 2025
Closed
1 task
@milinddethe15
feat: automate the release
fa1e82f 
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
@google-oss-prow google-oss-prow bot added size/L and removed size/XXL labels May 2, 2025
@milinddethe15 milinddethe15 changed the title Automate release feat: automate releases using script May 2, 2025
@milinddethe15 milinddethe15 marked this pull request as ready for review May 2, 2025 20:23
@coveralls
Copy link
coveralls commented May 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14912026962

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.807%
Totals Coverage Status
Change from base Build 14890359838: 0.0%
Covered Lines: 840
Relevant Lines: 2916
💛 - Coveralls

@milinddethe15
ci: validate the manifests image tag in release
93bc01d 
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
@Doris-xm Doris-xm mentioned this pull request May 5, 2025
Closed
7 tasks
@milinddethe15
Merge branch 'master' into automate-release
83c3e3f 
Signed-off-by: M!l!nd <99114125+milinddethe15@users.noreply.github.com>
@milinddethe15 milinddethe15 requested a review from andreyvelich May 8, 2025 17:07
@Electronic-Waste Electronic-Waste mentioned this pull request May 9, 2025
Merged
1 task
@andreyvelich andreyvelich mentioned this pull request May 28, 2025
Open
3 tasks
@github-actions GitHub Actions
Copy link
github-actions bot commented Aug 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@kramaranya
Copy link
Contributor

/remove-lifecycle stale

@andreyvelich
Copy link
Member

Hi @milinddethe15, since we release the v2.0.0, do you want to finalize this release automation work for the future releases (e.g. v2.1)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electronic-Waste Electronic-Waste Awaiting requested review from Electronic-Waste

@jinchihe jinchihe Awaiting requested review from jinchihe

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Kubeflow Trainer release process
4 participants
@milinddethe15 @coveralls @kramaranya @andreyvelich
0