E53D feat: Implement Kubernetes Backend by szaher · Pull Request #68 · kubeflow/sdk · GitHub
[go: up one dir, main page]

Skip to content

Conversation

szaher
Copy link
Member
@szaher szaher commented Aug 22, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <eng.szaher@gmail.com>
@coveralls
Copy link
coveralls commented Aug 22, 2025

Pull Request Test Coverage Report for Build 17222271301

Details

  • 163 of 241 (67.63%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 65.033%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kubeflow/trainer/utils/utils.py 0 10 0.0%
kubeflow/trainer/backends/kubernetes/backend.py 163 231 70.56%
Totals Coverage Status
Change from base Build 17059769083: 0.4%
Covered Lines: 292
Relevant Lines: 449

💛 - Coveralls

Signed-off-by: Saad Zaher <eng.szaher@gmail.com>
Copy link
Member
@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szaher!

@szaher szaher mentioned this pull request Aug 22, 2025
1 task
szaher and others added 3 commits August 23, 2025 00:27
Signed-off-by: Saad Zaher <eng.szaher@gmail.com>
Kubernetes client configuration isn't supported as pydantic core
schema so we need to ask pydantic to allow arbitrary types.

Signed-off-by: Saad Zaher <eng.szaher@gmail.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
szaher and others added 3 commits August 25, 2025 13:17
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <eng.szaher@gmail.com>
Signed-off-by: Saad Zaher <eng.szaher@gmail.com>
Copy link
Member
@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution @szaher!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7dff591 into kubeflow:main Aug 25, 2025
9 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Aug 25, 2025
@szaher szaher deleted the kubernetes-backend branch August 25, 2025 22:48
@kramaranya kramaranya mentioned this pull request Aug 8, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0