8000 fix(trainer): Keep the original runtime command in get_runtime_packages() API by andreyvelich · Pull Request #64 · kubeflow/sdk · GitHub
[go: up one dir, main page]
Skip to content

fix(trainer): Keep the original runtime command in get_runtime_packages() API #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

fix(trainer): Keep the original runtime command in get_runtime_packages() API #64

merged 1 commit into from
Aug 19, 2025

Conversation

andreyvelich
Copy link
Member

We should not modify the runtime's trainer command when user calls get_runtime_packages() API.

/assign @kubeflow/wg-training-leads @astefanutti @kramaranya @szaher

@andreyvelich
fix(trainer): Preserve the original runtime command in get_runtime_pa…
10deb23 
…ckages() API

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17055450797

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.877%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kubeflow/trainer/api/trainer_client.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
kubeflow/trainer/api/trainer_client.py 1 70.0%
kubeflow/trainer/utils/utils.py 1 58.9%
Totals Coverage Status
Change from base Build 16835759485: 0.2%
Covered Lines: 290
Relevant Lines: 447
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17055450797

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.877%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kubeflow/trainer/api/trainer_client.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
kubeflow/trainer/api/trainer_client.py 1 70.0%
kubeflow/trainer/utils/utils.py 1 58.9%
Totals Coverage Status
Change from base Build 16835759485: 0.2%
Covered Lines: 290
Relevant Lines: 447
💛 - Coveralls

@coveralls
Copy link

Pull 8000 Request Test Coverage Report for Build 17055450797

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.877%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kubeflow/trainer/api/trainer_client.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
kubeflow/trainer/api/trainer_client.py 1 70.0%
kubeflow/trainer/utils/utils.py 1 58.9%
Totals Coverage Status
Change from base Build 16835759485: 0.2%
Covered Lines: 290
Relevant Lines: 447
💛 - Coveralls

Electronic-Waste
Electronic-Waste reviewed Aug 19, 2025
View reviewed changes
Copy link
Member
@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich Thanks for this!
/approve
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 19, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5c36681 into kubeflow:main Aug 19, 2025
9 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Aug 19, 2025
@andreyvelich andreyvelich deleted the fix-copy-get-packages branch August 19, 2025 08:51
accorvin pushed a commit to opendatahub-io/kubeflow-sdk that referenced this pull request Oct 8, 2025
@andreyvelich @accorvin
fix(trainer): Keep the original runtime command in get_runtime_packag…
c75cec7 
…es() API (kubeflow#64)

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti Awaiting requested review from astefanutti

1 more reviewer

@Electronic-Waste Electronic-Waste Electronic-Waste left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Electronic-Waste Electronic-Waste

Labels
approved lgtm size/S
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@andreyvelich @coveralls @Electronic-Waste
0