chore: move pyproject.toml to root #61
Conversation
Pull Request Test Coverage Report for Build 16802473871Details
💛 - Coveralls |
pyproject.toml
Outdated
| [tool.hatch.build.targets] | ||
| packages = ["kubeflow"] | ||
| [tool.hatch.build.targets.wheel] | ||
| sources = ["python"] |
There was a problem hiding this comment.
packages = ["kubeflow"] worked when pyproject.toml was in the python/ directory because it could find kubeflow/ directly, but after moving pyproject.toml to the root, it would look for kubeflow/ at the root level which doesn't exist.
It works well with sources = ["python"] and python/kubeflow/ gets installed as kubeflow/ in site-packages with correct imports like from kubeflow.trainer import ... instead of from python.kubeflow.trainer import ... that would happen with packages = ["python/kubeflow"].
Alternatively, we could move the source code from python/kubeflow/ to just kubeflow/ at the root and keep using packages = ["kubeflow"].
There was a problem hiding this comment.
Let's remove the python directory since it is not required, and keep packages=["kubeflow"]
50ee6aa to
7cbfa46
Compare
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
This reverts commit 06a5bc4. Signed-off-by: kramaranya <kramaranya15@gmail.com>
7cbfa46 to
4172c45
Compare
Signed-off-by: kramaranya <kramaranya15@gmail.com>
| line-length = 100 | ||
|
|
||
| [tool.ruff.lint] | ||
| select = ["E", "F", "W"] |
There was a problem hiding this comment.
Shall we also move version file to: kubeflow/__init__.py ?
Lines 49 to 50 in 1c115c6
There was a problem hiding this comment.
Yep, that makes sense!
Signed-off-by: kramaranya <kramaranya15@gmail.com>
|
I'll also update Trainer and Website repos to use |
I think, we should also update the Trainer E2Es: https://github.com/kubeflow/trainer/blob/master/.github/workflows/test-e2e.yaml#L44 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've moved
pyproject.tomlto root and updated license path to align with https://peps.python.org/pep-0639/#add-string-value-to-license-key/assign @andreyvelich @astefanutti @Electronic-Waste @tenzen-y