-
Notifications
You must be signed in to change notification settings - Fork 35
feat(docs): add ROADMAP of Kubeflow SDK #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @szaher @andreyvelich @briangallagher @franciscojavierarceo @eoinfennessy @tenzen-y @Electronic-Waste @astefanutti |
Pull Request Test Coverage Report for Build 16662594446Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kramaranya Thanks for this! Just one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we include the work we've already done? Such as "Migrate Trainer SDK".
WDYT👀 @kramaranya @kubeflow/wg-training-leads @astefanutti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for driving this @kramaranya!
I am wondering if we also want to cover these:
- #23
- https://github.com/kubeflow/trainer/issues/2347
- Allow to configure initializer via SDK, it is required for cache: kubeflow/trainer#2655
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Anya Kramar <akramar@redhat.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: kramaranya <kramaranya15@gmail.com>
I think it would be great to have those for this year! I've updated the Roadmap, @andreyvelich @Electronic-Waste let me please know if I should update anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add an item for supporting other built-in trainers in the SDK, in addition to TorchTune as being discussed in kubeflow/trainer#2752?
I think, we should also track generation of docs for Kubeflow SDK, similar to KFP, and Model Registry: #50 |
Signed-off-by: kramaranya <kramaranya15@gmail.com>
I've added the issues to the roadmap, let me know if there's anything else I'm missing @astefanutti @andreyvelich @Electronic-Waste |
Let's discuss the Kubeflow SDK ROADMAP as part of tomorrow's call, so we can finalize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great ROADMAP @kramaranya!
/lgtm
/hold for others to review
/assign @kubeflow/kubeflow-trainer-team @astefanutti @shravan-achar @akshaychitneni @briangallagher @franciscojavierarceo @szaher @eoinfennessy @jskswamy @ned2
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we can merge this initial version, and improve it over time!
Thanks @kramaranya!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for the reviews! |
Nice! |
ROADMAP of Kubeflow SDK for 2025