10BC0 Consume Trainer models from external package kubeflow_trainer_api by kramaranya · Pull Request #15 · kubeflow/sdk · GitHub
[go: up one dir, main page]
Skip to content

Consume Trainer models from external package kubeflow_trainer_api #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

Consume Trainer models from external package kubeflow_trainer_api #15

merged 2 commits into from
Jun 9, 2025

Conversation

kramaranya
Copy link
Contributor

What this PR does / why we need it:
This PR replaces duplicate model definitions in the SDK with imports from the kubeflow_trainer_api package.
Added kubeflow_trainer_api as a git dependency since it's not yet published to PyPI and removed duplicate models.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #9

Checklist:

  • Docs included if any changes are user facing

@kramaranya
refactor: import models from kubeflow_trainer_api
e65aa7a 
Signed-off-by: kramaranya <kramaranya15@gmail.com>
eoinfennessy
eoinfennessy suggested changes Jun 6, 2025
View reviewed changes
Copy link
Member
@eoinfennessy eoinfennessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested. Otherwise LGTM!

@google-oss-prow Google OSS Prow
Copy link

@eoinfennessy: changing LGTM is restricted to collaborators

In response to this:

One small change requested. Otherwise LGTM!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kramaranya
refactor: update import statements for models
9475282 
Signed-off-by: kramaranya <kramaranya15@gmail.com>
eoinfennessy
eoinfennessy approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member
@eoinfennessy eoinfennessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-prow Google OSS Prow
Copy link

@eoinfennessy: changing LGTM is restricted to collaborators

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andreyvelich
andreyvelich reviewed Jun 9, 2025
View reviewed changes
Copy link
Member
@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @kramaranya!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 9, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d04f157 into kubeflow:main Jun 9, 2025
2 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Jun 9, 2025
@kramaranya kramaranya mentioned this pull request Jun 20, 2025
Merged
@kramaranya kramaranya deleted the import-trainer-models branch August 8, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@Electronic-Waste Electronic-Waste Awaiting requested review from Electronic-Waste

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

+1 more reviewer

@eoinfennessy eoinfennessy eoinfennessy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andreyvelich andreyvelich

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

Consume Trainer models from external package
3 participants
@kramaranya @andreyvelich @eoinfennessy
0