Add support for webp extension texture in gltf importer. #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
I encounted one problem that glb models generated by microsoft trellis 2.0 cannot be loaded. It shows an error:
Something went wrong
Failed to import model.
Unsupported extension: EXT_texture_webp.
So I decided to fix it.
Summary of Changes:
Added EXT_texture_webp to the list of supported extensions
Added 'EXT_texture_webp' to the supportedExtensions array
Handled the WebP extension in the texture import method
Checked whether the texture uses the EXT_texture_webp extension
If the extension is used, retrieved the correct image index from the extension
How it Works:
The EXT_texture_webp extension allows glTF files to use WebP format textures as an alternative to traditional formats like PNG or JPEG. When a texture object includes this extension, it specifies an alternative image source index that points to a WebP-formatted image.
WebP format is natively supported by browsers, so no additional decoding library is needed.