Updated Bubble Sort description #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the runtime, memory and a better description of bubble sort. The implementation was not added but it is good to know the concept.
Yes, and in my opinion it shouldn't be. ;-) |
|
Haha yeah true, it teaches a brute force approach. That is why I just added a description of the algorithm and no implementation keeping with what was implemented before. @hollance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Changes
Added the runtime, memory and a better description of bubble sort. The implementation was not added but it is good to know the concept.
Discussion
Even if the algorithm is "horrible" a description of it should be added for developers to grasp the concept of bubble sort. Bubble sort is a very common sorting technique taught when beginning to learn sorting algorithms. I do believe the algorithm should be implemented and shown but that is a change for another day.