8000 VERSION: update minimal version from 8 -> 12 by etroynov · Pull Request #152 · koajs/router · GitHub
[go: up one dir, main page]
Skip to content

VERSION: update minimal version from 8 -> 12 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

VERSION: update minimal version from 8 -> 12 #152

merged 1 commit into from
Jul 4, 2022

Conversation

etroynov
Copy link
Contributor
@etroynov etroynov commented Jun 26, 2022 •
edited
Loading

Hi,

According to error log I found what some of our deps require minimal node version 12
koa_1

Deps ( minimal node version )

I installed node.js version 8 and tried run tests:
koa_2

For this reason, I thought it was necessary to raise the node version from 8 -> 12

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@etroynov
Copy link
Contributor Author

@niftylettuce @3imed-jaberi what do you think about it?

@SagnikPradhan
Copy link

Since v14 is the last maintained node version, you could set it to that.

@etroynov
Copy link
Contributor Author
etroynov commented Jun 27, 2022 •
edited
Loading

@SagnikPradhan yes but in koa minimal version set as 12, for this reason, I decided to set the same version because it will be strange if the router will use version 14.

@titanism titanism merged commit 6ba3efa into koajs:master Jul 4, 2022
@titanism
Copy link
Contributor
titanism commented Jul 4, 2022

We have just published @koajs/router v11.0.0 which resolves this issue. This is mirrored to koa-router as well.

https://github.com/koajs/router/releases/tag/v11.0.0

This project is maintained by Forward Email and Lad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etroynov @SagnikPradhan @titanism
0