8000 update labelsNode to match new labels interface in kube 1.34 by ecordell · Pull Request #1545 · ko-build/ko · GitHub
[go: up one dir, main page]
Skip to content

update labelsNode to match new labels interface in kube 1.34 #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update labelsNode to match new labels interface in kube 1.34 #1545

wants to merge 1 commit into from

Conversation

@ecordell
Copy link
@ecordell ecordell commented Aug 5, 2025

Ran into this when pulling ko in as a library:

# github.com/google/ko/pkg/resolve
pkg/resolve/selector.go:107:26: cannot use labelsNode{…} (value of struct type labelsNode) as labels.Labels value in argument to selector.Matches: labelsNode does not implement labels.Labels (missing method Lookup)
pkg/resolve/selector.go:149:23: cannot use labelsNode{} (value of struct type labelsNode) as labels.Labels value in variable declaration: labelsNode does not implement labels.Labels (missing method Lookup)

I updated the l 8000 abelsNode implementation to match the new interface. I didn't update the apimachinery dependency in this PR; I'm assuming that ko prefers to track released versions only. This should mean that when it's time to update, there are no conflicts.

@github-actions
Copy link
github-actions bot commented Nov 4, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@ecordell ecordell mentioned this pull request Nov 7, 2025
Closed
@jkyros jkyros mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lifecycle/stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ecordell
0