8000 feat: add ko test command to build with go test -c by vincent-d · Pull Request #1407 · ko-build/ko · GitHub
[go: up one dir, main page]
Skip to content

feat: add ko test command to build with go test -c #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add ko test command to build with go test -c #1407

wants to merge 3 commits into from

Conversation

@vincent-d
Copy link
@vincent-d vincent-d commented Sep 25, 2024

Add a new command to build images with the output of go test -c.

It allows configuring build and LD flags in .ko.yaml with different values for build and test commands for a given importpath.

This is a new attempt at implementing #96 with a separate command.

cpanato
cpanato requested changes Sep 25, 2024
View reviewed changes
Copy link
Member
@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments for now

@vincent-d
feat: add ko test command to build with go test -c
0b8545f 
Add a new command to build images with the output of go test -c.

It allows configuring build and LD flags in .ko.yaml with different
values for build and test commands for a given importpath.
@vincent-d
fixup! feat: add ko test command to build with go test -c
854fbcd
@vincent-d
fixup! fixup! feat: add ko test command to build with go test -c
8d932eb
@vincent-d vincent-d force-pushed the feat/add-ko-test-command branch from 55a1914 to 8d932eb Compare November 5, 2024 11:03
@github-actions
Copy link
github-actions bot commented Feb 4, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@StevenACoffman
Copy link
Contributor
StevenACoffman commented Feb 4, 2025

Oh noes! This could be helpful!

@github-actions
Copy link
github-actions bot commented May 6, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@cpanato cpanato closed this Jun 2, 2025
@cpanato cpanato reopened this Jun 2, 2025
@github-actions
Copy link
github-actions bot commented Sep 1, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@clementnuss
Copy link
clementnuss commented Sep 22, 2025

what is missing in this PR?

not being able to compile test binaries with ko is a blocker. hope someone finds the time to merge this 🙏🏼

@github-actions github-actions bot 6CCA removed the lifecycle/stale label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vincent-d @StevenACoffman @clementnuss @cpanato
0