10000 Support `concat` a/v params by kkroening · Pull Request #97 · kkroening/ffmpeg-python · GitHub
[go: up one dir, main page]
Skip to content

Support concat a/v params #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2018
Merged

Support concat a/v params #97

merged 1 commit into from
Jun 30, 2018

Conversation

kkroening
Copy link
Owner
@kkroening kkroening commented Jun 30, 2018 •
edited
Loading

In order to concat both audio + video simultaneously, the concat filter must support a and v parameters and incorporate those values in the calculation for the output n value.

Without these changes, the test_filter_concat__audio_video fails with concat=n=4 instead of concat=n=2.

See AV pipeline example.

@kkroening kkroening requested a review from depau June 30, 2018 09:20
@kkroening kkroening merged commit 7c872c5 into master Jun 30, 2018
@kkroening kkroening deleted the concat-av branch June 30, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@depau depau Awaiting requested review from depau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kkroening
0