8000 Fix Black in GHA for Python 2.7 by kkroening · Pull Request #680 · kkroening/ffmpeg-python · GitHub
[go: up one dir, main page]

Skip to content

Fix Black in GHA for Python 2.7 #680

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix Black in GHA for Python 2.7 #680

merged 1 commit into from
Jul 11, 2022

Conversation

kkroening
Copy link
Owner

CI has started failing due to the following error when attempting to run Black:

ImportError: cannot import name '_unicodefun' from 'click' (/home/runner/work/_actions/psf/black/21.12b0/.black-env/lib/python3.8/site-packages/click/__init__.py)

The issue is described in Stack Overflow #71673404. But it's only problematic because of being tied to an older version of Black to support ancient Python 2.7 syntax.

We really need to kill off Python 2.7 support; but that's for a separate PR. This just stabilizes things for the time being.

(At least until Python 2.7 support is finally eliminated)
@kkroening kkroening merged commit ef00863 into master Jul 11, 2022
@kkroening kkroening deleted the KK/black-py27 branch July 11, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0