Allow to use different command other than 'ffmpeg' #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkroening
approved these changes
May 26, 2017
| args = ['ffmpeg'] + self.get_args() | ||
|
|
||
| def run(self, cmd='ffmpeg'): | ||
| if type(cmd) == str: |
There was a problem hiding this comment.
What would it be besides a string? Should there be an else?
There was a problem hiding this comment.
It could be a list.
You may want to run
["nice", "-n", "10", "ffmpeg"]There was a problem hiding this comment.
About the else you may want to check it is a supported iterable, but generally I don't do too many checks, the interpreter gives understandable tracebacks.
E.g.:
TypeError: unsupported operand type(s) for +: 'int' and 'list'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "cmd" argument to run that allows to provide different command for ffmpeg (e.g. you may want to use
avconvor a wrapper).