8000 Add support for Python3 (fixes #10) by kkroening · Pull Request #12 · kkroening/ffmpeg-python · GitHub
[go: up one dir, main page]

Skip to content

Add support for Python3 (fixes #10) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 16, 2017
Merged

Add support for Python3 (fixes #10) #12

merged 10 commits into from
Jun 16, 2017

Conversation

kkroening
Copy link
Owner
@kkroening kkroening commented Jun 14, 2017

I used futurify to add Python 3 support. Aside from the auto-generated import changes, only a few things needed to be changed:

  • Add __hash__ operator to Node class
  • Encode strings as utf-8 before sending to hashlib.md5
  • Change test_repr to use proper string representation.

In addition, the following features have been added:

  • Test multiple python versions using Tox
  • Make setup.py test DTRT
  • Add setup.py classifiers
  • Cache ffmpeg download on travis

Fixes #10.

8C86
@kkroening kkroening mentioned this pull request Jun 14, 2017
@kkroening kkroening changed the title Add support for Python3 Add support for Python3 (fixes #10) Jun 14, 2017
@kkroening kkroening merged commit 45f1494 into master Jun 16, 2017
@kkroening kkroening deleted the support-python3 branch June 16, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0