Openssl for Python 2.7.11 (mandatory dependency of Python 2.7.11) #774
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
¡¡¡ Closed because currently I'm working with python's version 2.7.12, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recipe is needed by PR #775 (Python 2.7.11).
This libraries are problematic because android already distributes an older version and we compile all the stuff against the latest version. This causes some troubles when we try to load the openssl libs from the app, because the android system loads first his own libs... and it is almost sure that the app will fail at some point when trying to call some function that not exist anymore, or maybe, is a newer function that not exist in the old libs.
Is for this that I decide to compile this libs as static instead of shared (I know that it increase a little bit the final size of the app but this way we make sure that all the calls to openssl libs will work as expected). Cause building as static libs maybe is not necessary for some recipes or bootstraps, I doubt so, if we need to add this libs into the final app, I decide to add the ability to build as static or shared (if the new python2 recipe is used it will be build as static, unless the user uses the variable "force_shared" set to True, otherwise it will be build as shared as always has been).
Merge Note: This could break the old python2 recipe...so, only should be merged if the Python 2.7.11 PR is accepted