8000 [revamp] Fixed some invalid python syntax errors in the pygame builds. Fixes #444 by dvenkatsagar · Pull Request #445 · kivy/python-for-android · GitHub
[go: up one dir, main page]
Skip to content

[revamp] Fixed some invalid python syntax errors in the pygame builds. Fixes #444 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2015
Merged

[revamp] Fixed some invalid python syntax errors in the pygame builds. Fixes #444 #445

merged 1 commit into from
Sep 12, 2015

Conversation

dvenkatsagar
Copy link
Contributor

@thopiekar

  • modified few files to support python 3 syntax.

I havent tested it though.

@dvenkatsagar dvenkatsagar changed the title Fixed some invalid python syntax errors in the pygame builds. Fixes #444 [revamp] Fixed some invalid python syntax errors in the pygame builds. Fixes #444 Sep 10, 2015
@thopiekar
Copy link
Contributor

Thanks! I'm sure @inclement will agree to merge your PR 😃

@dvenkatsagar
Copy link
Contributor Author

Glad to help

inclement added a commit that referenced this pull request Sep 12, 2015
@inclement
Merge pull request #445 from dvenkatsagar/python3_invalid_syntax
35284e6 
[revamp] Fixed some invalid python syntax errors in the pygame builds. Fixes #444
@inclement inclement merged commit 35284e6 into kivy:revamp Sep 12, 2015
@inclement
Copy link
Member

Thanks, this seems fine, though I'd expect that further changes would be needed for python3 to work with the pygame bootstrap - I did a python3 branch in the past for p4a and in that case added a full python3 version of jinja2. Maybe some simpler changes are enough though.

@dvenkatsagar dvenkatsagar deleted the python3_invalid_syntax branch September 12, 2015 13:50
@dvenkatsagar
Copy link
Contributor Author

I think the code should code should work in both 2.7.6 and 3.4 now. But if it still doesnt maybe we can do some changes in the future such that it would support both.

@dvenkatsagar dvenkatsagar restored the python3_invalid_syntax branch September 13, 2015 15:28
@dvenkatsagar dvenkatsagar deleted the python3_invalid_syntax branch September 13, 2015 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvenkatsagar @thopiekar @inclement
0