Updated pylibpd recipe. #433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Just to be clear, the [revamp] tag refers to the new revamp branch which is a somewhat different rewrite of python-for-android, but your changes are for the master branch, so I've removed the tag. We'll include your changes in the revamp as and when the recipes are ported, so don't worry about them being missed. |
|
Ok, thanks for the informations, have a nice day! |
|
I've merged this manually to the old toolchain. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of the patch refers to wrong line numbers and fails to patch the setup.py file.
I've updated the patch file creating a diff with the github repo version of setup.py.
Now the recipe uses git clone --recursive for downloading libpd so we can include all the submodules in one step.
The libpd makefile has been patched to be coherent with the pylibpd patch.