Resolve absolute path to local recipes #2640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary when using patches in a local recipe since `Recipe.apply_patch` assumes the recipe directory is absolute and uses `patch -d` to change directories. It could just be fixed there, but this ensures that recipe directories are always absolute. Closes: kivy#2623
31aa94e to
06c8103
Compare
misl6
added a commit
that referenced
this pull request
Sep 5, 2022
* Add option for copying arbitratry xml files to src/main/res/xml without touching manifest * handle the case of getting list as res_xml * Remove stray - in output file name The final component in the package name is just the extension, so prefixing it with a - means the output file ends in -.<ext>. * Resolve absolute path to local recipes (#2640) This is necessary when using patches in a local recipe since `Recipe.apply_patch` assumes the recipe directory is absolute and uses `patch -d` to change directories. It could just be fixed there, but this ensures that recipe directories are always absolute. Closes: #2623 * Fix webview Back button behaviour (#2636) * Fixes TypeError: str.join() takes exactly one argument (2 given) in hostpython3/__init__.py", line 69 (#2642) * Update __init__.py .buildozer/android/platform/python-for-android/pythonforandroid/recipes/hostpython3/__init__.py", line 69, in get_recipe_env env["PKG_CONFIG_PATH"] = os.pathsep.join( TypeError: str.join() takes exactly one argument (2 given) * according of #2642 (review) * RTSP support for ffmpeg Added UDP and TCP protocols to "--enable-procol" to supporting RTSP streams over each. Added RTSP to "--enable-demuxer" to supporting RTSP with ffmpeg. * Fixes some E275 - assert is a keyword. (#2647) * Add icon-bg and icon-fg to fix_args + adds a missing folder in webview dir template (#2633) * Add icon-bg and icon-fg to fix_args Fix the icon-bg and icon-fg arguments and also create the folder mipmap-anydpi-v26 if it doesn't exists before trying to create a file inside. * Use existing ensure_dir function to create anydpi_dir * Add mipmap-anydpi-v26 to bootstrap template This makes available the directory in the final template so it's not needed to check the directory exists. * Updates matplotlib, fixes an issue related to shared libc++ (#2645) * Updates matplotlib, fixes an issue related to shared libc++ * Cleanup * Update supported Python versions (#2656) * Remove six and enum34 dependency (#2657) * Force --platform=linux/amd64 in Dockerfile (#2660) * Use p4a_install instead of install, as a file named INSTALL is already present. (#2663) * Update CHANGELOG.md & change version for release 2022.09.04 Co-authored-by: Eero af Heurlin <eero.afheurlin@iki.fi> Co-authored-by: Dan Nicholson <dbn@endlessos.org> Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> Co-authored-by: Andy Trofimov <interlark@gmail.com> Co-authored-by: Akshay Arora <akshayaurora@gmail.com> Co-authored-by: --=FurtiF™=-- <Furtif@users.noreply.github.com> Co-authored-by: alickc <ali.cakici@eyedius.com> Co-authored-by: danigm <dani@danigm.net>
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
This is necessary when using patches in a local recipe since `Recipe.apply_patch` assumes the recipe directory is absolute and uses `patch -d` to change directories. It could just be fixed there, but this ensures that recipe directories are always absolute. Closes: kivy#2623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when using patches in a local recipe since
Recipe.apply_patchassumes the recipe directory is absolute and usespatch -dto change directories. It could just be fixed there, but thisensures that recipe directories are always absolute.
Closes: #2623