8000 Fixed libzqm recipe linking issues by hpsaturn · Pull Request #1803 · kivy/python-for-android · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@hpsaturn
Copy link
Contributor

fixed crtbegin_so.o crtend_so.o link errors described here

solution: adding sysroot compiler option

Also:
-- updated ZMQ library version from github releases
-- a little fiexes on env vars
-- added method for include directories

…ption

Also:
-- updated ZMQ library version from github releases
-- a little fiexes on env vars
-- added method for include directories
@AndreMiras
Copy link
Member

Nice thank you for the PR.
I've added a comment regarding the linting error:

pythonforandroid/recipes/libzmq/__init__.py:76:29: E231 missing whitespace after ','

We need to have it fix for the CI, to automatically compile your recipe. Could you address that?

Copy link
Member
@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@AndreMiras AndreMiras merged commit e4cecb1 into kivy:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0