Fix linkage problems with python's versioned library (reintroduce INSTSONAME)
#1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…STSONAME`) We fix this issue by re-introducing `INSTSONAME`. This variable has been used in all our python recipes, because allow us to remove the version of the compiled python library which is mandatory, at the time of writing, because android does not support versioned libraries (the Java method called to load the libraries only supports a .so suffix). A little history, because I didn't find any official documentation for this variable, and **it's quite important for us**: - This variable it's not hacked, it's official and was introduced a long time ago, forms part of the python's shared library building process (python/cpython@1142de3) - @tito introduced this variable almost at the beginning of the p4a project in (bdefea1) - @inclement also make use of it when he reworked the python2 recipe (4c8b5bc) - this variable still exists in the current python2 recipe and we make use of it precisely to solve the mentioned android's libraries version problem - Somehow, during the process of making the new python3 recipe, we loose this variable and then, we begin to have linkage problems at runtime with our python library as described in issue kivy#1501 Note: ¡¡¡Special thanks to @Jonast!!!...to force me to search this information ;) References: python/cpython@1142de3, bdefea1 and 4c8b5bc Resolves: kivy#1501
efcb66f to
f73503c
Compare
INSTSONAME)INSTSONAME)
ghost
approved these changes
Jan 9, 2019
| if self.major_minor_version_string[0] == '3': | ||
| py_version += 'm' | ||
| shprint(sh.make, 'all', | ||
| 'INSTSONAME=libpython{version}.so'.format( |
There was a problem hiding this comment.
after discussion this looks like the right way to do it! I think this is a good change
KeyWeeUsr
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix this issue by re-introducing
INSTSONAME. This variable has been used in all our python recipes, because allow us to remove the version of the compiled python library which is mandatory, at the time of writing, because android does not support versioned libraries (the Java method called to load the libraries only supports a .so suffix).A little history, because I didn't find any official documentation for this variable, and it's quite important for us:
Note: ¡¡¡Special thanks to @Jonast!!!...to force me to search this information ;)
References: python/cpython@1142de3, bdefea1 and 4c8b5bc
Resolves: #1501
If there is some planning to merge #1537 soon, maybe it would be better not to merge this, to avoid fixing merge conflicts in there.I think that it would be less problematic for all of us to fix the merge conflicts in here.