8000 Update gradle version by opacam · Pull Request #1507 · kivy/python-for-android · GitHub
[go: up one dir, main page]
Skip to content

Update gradle version #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
inclement merged 1 commit into from
Dec 9, 2018
Merged

Update gradle version #1507

inclement merged 1 commit into from
Dec 9, 2018

Conversation

@opacam
Copy link
Member
@opacam opacam commented Dec 9, 2018

To solve the ci errors when trying to download the corresponding build tools which seems to not exist anymore...

Resolves: #1506

@opacam
Update gradle version
d8e3d51 
To solve the ci errors when trying to download the corresponding build tools which seems to not exist anymore...

Resolves: kivy#1506
ghost
ghost approved these changes Dec 9, 2018
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test build with python 2 / API 19 with ndk-bundle 19 / openjdk8 was successful with this new change. (For anyone who wants to reproduce what I ran: sudo p4aspaces cmd p4a-py2-api19-ndkbundle testbuild --p4a https://github.com/opacam/python-for-android/archive/fix-ci-gradle.zip)

@ghost
Copy link
ghost commented Dec 9, 2018 •
edited by ghost
Loading

I did an additional build of the testapp_keyboard with Python 3 non-crystax / API 28 + NDK 21 / openjdk8 (p4aspaces' p4a-py3-api28ndk21 env) with this pull request because you know, I don't have much better things to do... and that one also worked. Haven't tested the .apk though, but the build runs through fine including the gradle step.

@opacam
Copy link
Member Author
opacam commented Dec 9, 2018

I did test an apk at run time and it seems to work as expected (only python2 tested but it should work for python 3 because I tested with the changes made in pr #1460, so both versions of python shares the same build system). The nature of the failure makes me think that all the ci builds made after the removed build tools will fail, unless restored the build tools...I don't know if we can rely on this...

The only visible difference (in functionality) I find is that the resulting apk's path has been changed into a sub folder (debug or release).

I must say that with this pr the most of the gradle dependencies will be downloaded from google...this will make the build system more reliable? hope that yes...

@inclement inclement merged commit 7f8242f into kivy:master Dec 9, 2018
@inclement
Copy link
Member
inclement commented Dec 9, 2018

Thanks!

This was referenced Dec 10, 2018
Closed
Closed
tito
tito reviewed Jan 4, 2019
View reviewed changes
@opacam opacam deleted the fix-ci-gradle branch June 7, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tito tito tito left review comments

@inclement inclement inclement approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@opacam @inclement @tito
0