Fix broken --ndk-api default value #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was no change with that force push, I just rebased onto latest master so I could locally pile up all the pull requests I currently depend on 😢 |
|
#1472 provides a different fix that addresses the root cause better, but if this improves things then it seems fine to merge for now. Thanks. |
inclement
approved these changes
Nov 23, 2018
|
When it was None I got tons of errors and couldnt build the apk, but @tshirtman solution worked like charm ! 0 is better and buit the apk on the fly. if you woried bout that line just replace: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this by accident while making the other pull requests.
--ndk-apidefaults to0in the parser, but code in other places (e.g.distribution.py) expects it to beNoneif not set. This breaks locating the proper final distribution in some cases when it's not specified, therefore I suggest this should be fixed.