8000 Put install_reqs on line so that buildozer's rubbish parsing will work by inclement · Pull Request #1413 · kivy/python-for-android · GitHub
[go: up one dir, main page]
Skip to content

Put install_reqs on line so that buildozer's rubbish parsing will work #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2018
Merged

Put install_reqs on line so that buildozer's rubbish parsing will work #1413

merged 1 commit into from
Oct 19, 2018

Conversation

inclement
Copy link
Member

This is currently making buildozer fail because it tries to parse the line with a regex.

AndreMiras
AndreMiras previously approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member
@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a bit special hack from buildozer it probably deserves a ticket if not at least a code comment before somebody else breaks it

@AndreMiras AndreMiras mentioned this pull request Oct 19, 2018
Closed
@inclement @AndreMiras
On line install_reqs to peace buildozer's parsing
f0d5dd6 
This is currently making buildozer fail because it tries to parse the
line with a regex, refs:
kivy/buildozer#722
AndreMiras
AndreMiras approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member
@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the comment and edited the commit message to reference the technical debt task and to comply with 50/72 rule

@AndreMiras AndreMiras merged commit da10e50 into master Oct 19, 2018
@AndreMiras AndreMiras deleted the inclement-patch-1 branch October 19, 2018 11:50
AndreMiras referenced this pull request Oct 19, 2018
@AndreMiras
Conditional recipe build fixes #1382
7dd7d17 
This is a first iteration addressing recipes conditional build.
In this version all modified recipes are build in batch with no
dependency resolution whatsoever.
Also recipes are only built against `python3crystax` target and
`sdl2` bootstrap.
The list of broken recipes is not fully known, but this script will help
finding out. If a recipe is known to be broken, it should be added in
the `BROKEN_RECIPES` set to be skipped until it gets fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inclement @AndreMiras
0