Fixes Python3.6 and enum34 #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module `enum34` should only be installed on Python < 3.4 Fixes host Python3 regression from ecd0bf6, the error was: ``` AttributeError: module 'enum' has no attribute 'IntFlag' ```
|
I wish I could verify that in a unit test, but can't seem to reproduce that when running from tox. And it's bit overkill to write an integration test for it because it would require updating our CI to run also on host Python3 😕 |
inclement
reviewed
Oct 11, 2018
| @@ -16,7 +16,8 @@ | |||
| data_files = [] | |||
|
|
|||
|
|
|||
| install_reqs = ['appdirs', 'colorama>=0.3.3', 'jinja2', 'six', 'enum34'] | |||
| install_reqs = ['appdirs', 'colorama>=0.3.3', 'jinja2', 'six', | |||
| 'enum34;python_version<"3.4"'] | |||
There was a problem hiding this comment.
I would indent this further, but no need to have that hold up fixing the install.
There was a problem hiding this comment.
True, well the linter (yes we have one 😄 ) didn't complain, but you're right I could have at least tried something like:
install_reqs = [
'appdirs', 'colorama>=0.3.3', 'jinja2', 'six', 'enum34;python_version<"3.4"'
]
inclement
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
enum34should only be installed on Python < 3.4Fixes host Python3 regression from ecd0bf6, the error was: