This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
rc.shutdown: fix premature unmounting of pseudo-filesystems #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing the
-tflag to umount, the "no" prefix applies to the whole list of fs types, not just the one that it prefixes (see umount man page or libbb/match_fstype.c in busybox source code). Currently, umount tries to ignore "noproc", "nodevtmpfs" and "notmpfs", due to the "no" prefix on "sysfs". They obviously do not match "proc", "devtmpfs" and "tmpfs", meaning these filesystems get unintentionally and prematurely unmounted. This leads to errors about not being able to read/proc/mountson shutdown.This fixes the issue by correctly prefixing just the whole list, rather than each filesystem type.