E51E fix call executeXmlRpcCall in methods removePlatformFromTestPlan in class TestPlanService by poncoe · Pull Request #153 · kinow/testlink-java-api · GitHub
[go: up one dir, main page]

Skip to content

fix call executeXmlRpcCall in methods removePlatformFromTestPlan in class TestPlanService#153

Merged
kinow merged 1 commit intokinow:masterfrom
poncoe:master
Jul 24, 2024
Merged

fix call executeXmlRpcCall in methods removePlatformFromTestPlan in class TestPlanService#153
kinow merged 1 commit intokinow:masterfrom
poncoe:master

Conversation

@poncoe
Copy link
@poncoe poncoe commented Jul 24, 2024

Hi Mr @kinow

In Class TestPlanService have methods name removePlatformFromTestPlan, but in Object Response executeXmlRpcCall, the methods call TestLinkMethods.ADD_PLATFORM_TO_TEST_PLAN should call TestLinkMethods.REMOVE_PLATFORM_FROM_TEST_PLAN.

i found this bug when i doing implement your method removePlatformFromTestPlan but my platform wont remove and always in Assign Platforms in testlink, when i execute the method should my platform in Available Plaforms.

Regards

Copy link
Owner
@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!!! I think I never used it in the Jenkins testlink plugin, but I am still surprised nobody else complained about it until now 🙂 Merging, thanks!

@kinow kinow merged commit f3f29d5 into kinow:master Jul 24, 2024
@kinow
Copy link
Owner
kinow commented Jul 24, 2024

@poncoe would you like this to be released to Maven now? Or, if you are still testing things, we can wait a few days to see if you find anything else missing/broken, and include in the next release. Let me know what you prefer. Thanks!

@poncoe
Copy link
Author
poncoe commented Jul 24, 2024

Hi Mr @kinow,

Can you wait until July 27? in this time, i currently implement some method in your library for my project, maybe if i found issue, i will create github issue or trying to solving & merging.

If possible, can you create a method to create platform? because I think it would be helpful if there was this method (create Platform). thanks

Regards

@kinow
Copy link
Owner
kinow commented Jul 24, 2024

Not a problem for me. Take your time. Unfortunately I don't have TestLink installed at the moment (my current job is not using it, and I have limited time to volunteer right now).

If there's a method to create platform in the PHP XMLRPC API, then it would be a matter of copying an existing method and replacing the method name by the correct one, and adjusting the parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0