8000 [MRG] ENH: Support centering in LogisticRegression by kernc · Pull Request #1 · kernc/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG] ENH: Support centering in LogisticRegression #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

kernc
Copy link
Owner
@kernc kernc commented Mar 17, 2016

Please try to adhere to the guidelines below as much as possible when submitting your pull request.

  • Please verify that your code satisfies the
    code/documentation quality guidelines.
  • Please prefix the title of your pull request with [MRG] if the
    contribution is complete and should be subjected to a detailed review.
  • Incomplete contributions should be prefixed [WIP] to indicate a work
    in progress (and changed to [MRG] when it matures). WIPs may be useful
    to: indicate you are working on something to avoid duplicated work,
    request broad review of functionality or API, or seek collaborators.
    WIPs often benefit from the inclusion of a
    task list
    in the PR description.
  • Documentation and high-coverage tests are necessary for enhancements to
    be accepted.
  • If you are adding an enhancement, you may wish to provide evidence for
    its benefit with distinguishing examples in the code and benchmarks
    in the PR discussion.
  • If your pull request addresses an issue, please use the title to describe
    the issue and mention the issue number in the pull request description to
    ensure a link is created to the original issue.

Please be aware that we are a loose team of volunteers so patience is
necessary; assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
For more information, see
Why is my PR not getting any attention?

Thanks for contributing! Please delete these guidelines before submitting your pull request.

@kernc
Copy link
Owner Author
kernc commented Mar 17, 2016

@lanzagar, please provide preliminary review. I don't know what I'm doing. 😆

@kernc kernc force-pushed the center-logistic-regression branch from 7449cca to 5fdc482 Compare March 18, 2016 13:03
MechCoder and others added 4 commits March 18, 2016 23:23
[MRG+1] Fix: FeatureHasher now accepts string values
[MRG+1] Fix to documentation and docstring of randomized lasso and randomized logistic regression
…weak

[MRG+1] Do not ignore files starting with _ and . in nose
@kernc kernc force-pushed the center-logistic-regression branch from 5fdc482 to d9040ff Compare March 19, 2016 23:36
bryandeng and others added 13 commits March 20, 2016 19:10
…r-and-remove-unused-variable-in-multiclass

[MRG] FIX Fix NameError ("estimator" not defined). Remove unused var "ind".
…_fix

[MRG+1] LabelBinarizer single label case now works for sparse and dense case
Fixing minor typos and inconsistencies in logistic regression docs
Added the following things:
* Test when the sum is not equal to one
* Test the prediction in case of a large bias for one class
* Test explicitely class_prior_
* Move the function to update the class prior in the GaussianNB class
* Remove the updating of the class prior before to actually compute the mean and variance

Address comments for PR scikit-learn#6180 - Correct the documentation

Address comment PR#6180 - Improve the class prior initialisation and updating
We modify the code to:
* Initialisat self.class_prior_ with the different possibilities (class_prior given or not, fit_prior True or False)
* Update self.class_prior_ only when no class_prior is given and than fit_prior is True

Address comments PR scikit-learn#6180 - Remove useless line

Fix the file according to PEP8 regulations

Update the API to have only class_prior in GaussianNB

Correct prior fitting using samples and not class number

Change name of priors and correct the warning with division by zero

Update the API

Remove functions which were called only once

Add additional test for part of the code which was not covered in GaussianNB

Correct doc formatting

Correct spelling
Error 404 in documentation section 2.7.1. Novelty Detection
@kernc kernc force-pushed the center-logistic-regression branch from d9040ff to 612cd9e Compare March 24, 2016 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0