forked from scikit-learn/scikit-learn
-
Notifications
You must be signed in to change notification settings - Fork 0
[MRG] ENH: Support centering in LogisticRegression #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kernc
wants to merge
33
commits into
master
Choose a base branch
from
center-logistic-regression
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, files starting with _ and setup.py are ignored by nose. This causes doctests to be skipped in _*.py modules.
added link to sclera.metrics.make_scorer
@lanzagar, please provide preliminary review. I don't know what I'm doing. 😆 |
7449cca
to
5fdc482
Compare
[MRG+1] Fix: FeatureHasher now accepts string values
[MRG+1] Fix to documentation and docstring of randomized lasso and randomized logistic regression
…weak [MRG+1] Do not ignore files starting with _ and . in nose
5fdc482
to
d9040ff
Compare
[MRG] Fix broken link in ABOUT
…r-and-remove-unused-variable-in-multiclass [MRG] FIX Fix NameError ("estimator" not defined). Remove unused var "ind".
…_fix [MRG+1] LabelBinarizer single label case now works for sparse and dense case
Fixing minor typos and inconsistencies in logistic regression docs
Added the following things: * Test when the sum is not equal to one * Test the prediction in case of a large bias for one class * Test explicitely class_prior_ * Move the function to update the class prior in the GaussianNB class * Remove the updating of the class prior before to actually compute the mean and variance Address comments for PR scikit-learn#6180 - Correct the documentation Address comment PR#6180 - Improve the class prior initialisation and updating We modify the code to: * Initialisat self.class_prior_ with the different possibilities (class_prior given or not, fit_prior True or False) * Update self.class_prior_ only when no class_prior is given and than fit_prior is True Address comments PR scikit-learn#6180 - Remove useless line Fix the file according to PEP8 regulations Update the API to have only class_prior in GaussianNB Correct prior fitting using samples and not class number Change name of priors and correct the warning with division by zero Update the API Remove functions which were called only once Add additional test for part of the code which was not covered in GaussianNB Correct doc formatting Correct spelling
Error 404 in documentation section 2.7.1. Novelty Detection
[MRG+1] MAINT: Simplify n_features_to_select logic in RFECV
…mlight_file-support-sparse-y [MRG+1] Make dump_svmlight_file support sparse y (fixes scikit-learn#6301)
[MRG+2] Fix for issue scikit-learn#6352
d9040ff
to
612cd9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please try to adhere to the guidelines below as much as possible when submitting your pull request.
code/documentation quality guidelines.
[MRG]
if thecontribution is complete and should be subjected to a detailed review.
[WIP]
to indicate a workin progress (and changed to
[MRG]
when it matures). WIPs may be usefulto: indicate you are working on something to avoid duplicated work,
request broad review of functionality or API, or seek collaborators.
WIPs often benefit from the inclusion of a
task list
in the PR description.
be accepted.
its benefit with distinguishing examples in the code and benchmarks
in the PR discussion.
the issue and mention the issue number in the pull request description to
ensure a link is created to the original issue.
Please be aware that we are a loose team of volunteers so patience is
necessary; assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
For more information, see
Why is my PR not getting any attention?
Thanks for contributing! Please delete these guidelines before submitting your pull request.