8000 Modified InputSpec of SpectralNormalization layer by sonali-kumari1 · Pull Request #21335 · keras-team/keras · GitHub
[go: up one dir, main page]
Skip to content

Modified InputSpec of SpectralNormalization layer #21335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2025
Merged

Modified InputSpec of SpectralNormalization layer #21335

merged 2 commits into from
Jun 1, 2025

Conversation

sonali-kumari1
Copy link
Contributor

Modified InputSpec of SpectralNormalization layer to handle multiple batch dimensions.
fixes #21320

@codecov-commenter
Copy link
codecov-commenter commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (de9cf25) to head (c46c423).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21335      +/-   ##
==========================================
+ Coverage   82.65%   82.68%   +0.02%     
==========================================
  Files         565      565              
  Lines       54823    54825       +2     
  Branches     8514     8515       +1     
==========================================
+ Hits        45315    45333      +18     
+ Misses       7414     7406       -8     
+ Partials     2094     2086       -8
Flag Coverage Δ
keras 82.49% <100.00%> (+0.02%) ⬆️
keras-jax 63.64% <100.00%> (+0.05%) ⬆️
keras-numpy 58.77% <100.00%> (+0.02%) ⬆️
keras-openvino 33.13% <0.00%> (-0.01%) ⬇️
keras-tensorflow 64.03% <100.00%> (+0.02%) ⬆️
keras-torch 63.67% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fchollet
fchollet approved these changes May 31, 2025
View reviewed changes
Copy link
Collaborator
@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- please add a simple unit test for the higher-dim case.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 31, 2025
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Jun 1, 2025
@stefanradev93 stefanradev93 mentioned this pull request Jun 1, 2025
Closed
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 1, 2025
@fchollet fchollet merged commit 3d2db56 into keras-team:master Jun 1, 2025
7 checks passed
@sonali-kumari1 sonali-kumari1 deleted the spectralNormTest branch June 2, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees

@gbaned gbaned

Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpectralNormalization layer fails on multiple batch dimensions
5 participants
@sonali-kumari1 @codecov-commenter @fchollet @kokoro-team @gbaned
0