8000 Fix a bug in error handling functions in lexer.py by iley · Pull Request #4 · kennknowles/python-jsonpath-rw · GitHub
[go: up one dir, main page]
Skip to content

Fix a bug in error handling functions in lexer.py #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2013
Merged

Fix a bug in error handling functions in lexer.py #4

merged 1 commit into from
Jun 21, 2013

Conversation

iley
Copy link
Contributor
@iley iley commented Jun 21, 2013

t.latest_newline was mistakenly used instead of t.lexer.latest_newline in t_singlequote_error(), t_doublequote_error() etc.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6a3063f on iley:master into 428f740 on kennknowles:master.

kennknowles added a commit that referenced this pull request Jun 21, 2013
@kennknowles
Merge pull request #4 from iley/master
5c41c53 
Fix a bug in error handling functions in lexer.py
@kennknowles kennknowles merged commit 5c41c53 into kennknowles:master Jun 21, 2013
@kennknowles
Copy link
Owner

Nice catch. Any chance I could get you to write a test for it? The error cases are rather poorly covered.

:-)

@iley
Copy link
Contributor Author
iley commented Jun 21, 2013

Sure. I'll write a test for this case.

@iley iley mentioned this pull request Jun 21, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iley @coveralls @kennknowles
0