8000 Update morning by kaocher82 · Pull Request #4 · kaocher82/cpython · GitHub
[go: up one dir, main page]
Skip to content

Update morning #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2021
Merged

Update morning #4

merged 3 commits into from
Mar 29, 2021

Conversation

kaocher82
Copy link
Owner

Morning path

@sourcery-ai sourcery-ai bot mentioned this pull request Mar 29, 2021
Merged
@sourcery-ai
Copy link
sourcery-ai bot commented Mar 29, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.88%.

Quality metrics Before After Change
Complexity 8.79 🙂 8.03 ⭐ -0.76 👍
Method Length 72.89 🙂 56.23 ⭐ -16.66 👍
Working memory 8.80 🙂 8.41 🙂 -0.39 👍
Quality 62.34% 🙂 65.22% 🙂 2.88% 👍
Other metrics Before After Change
Lines 167 223 56
Changed files Quality Before Quality After Quality Change
PCbuild/prepare_ssl.py 62.34% 🙂 65.22% 🙂 2.88% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
PCbuild/prepare_ssl.py main 14 🙂 215 ⛔ 9 🙂 46.16% 😞 Try splitting into smaller methods
PCbuild/prepare_ssl.py fix_uplink 8 ⭐ 81 🙂 10 😞 63.86% 🙂 Extract out complex expressions
PCbuild/prepare_ssl.py copy_includes 7 ⭐ 83 🙂 10 😞 64.51% 🙂 Extract out complex expressions
PCbuild/prepare_ssl.py prep 4 ⭐ 92 🙂 10 😞 66.14% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@kaocher82 kaocher82 merged commit 1d49545 into master Mar 29, 2021
@kaocher82 kaocher82 deleted the kaocher82-patch-dir branch March 29, 2021 22:19
@ghost
Copy link
ghost commented Mar 30, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kaocher82
0