Fix write_to_textfile leaves back temp files on errors (prometheus#1044) (prometheus#1066)

ethanschen · web-flow · commit c89624f784c3 · 2024-10-25T14:03:38.000-06:00
Signed-off-by: Ethan S. Chen &lt;ethanschen@163.com&gt;
diff --git a/prometheus_client/exposition.py b/prometheus_client/exposition.py
@@ -367,14 +367,19 @@ def write_to_textfile(path: str, registry: CollectorRegistry) -> None:
     This is intended for use with the Node exporter textfile collector.
     The path must end in .prom for the textfile collector to process it."""
     tmppath = f'{path}.{os.getpid()}.{threading.current_thread().ident}'
-    with open(tmppath, 'wb') as f:
-        f.write(generate_latest(registry))
+    try:
+        with open(tmppath, 'wb') as f:
+            f.write(generate_latest(registry))
 
-    # rename(2) is atomic but fails on Windows if the destination file exists
-    if os.name == 'nt':
-        os.replace(tmppath, path)
-    else:
-        os.rename(tmppath, path)
+        # rename(2) is atomic but fails on Windows if the destination file exists
+        if os.name == 'nt':
+            os.replace(tmppath, path)
+        else:
+            os.rename(tmppath, path)
+    except Exception:
+        if os.path.exists(tmppath):
+            os.remove(tmppath)
+        raise
 
 
 def _make_handler(
