This repository was archived by the owner on Oct 2, 2023. It is now read-only.
8000
WIP An initial implementation of cells #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| import { | ||
| IInputAreaViewModel | ||
| } from 'jupyter-js-input-area'; | ||
| import { |
|
Ran the example, looks good, I'd recommend adding this: diff --git a/package.json b/package.json
index 0c28fd5..c264851 100644
--- a/package.json
+++ b/package.json
@@ -58,6 +58,11 @@
"lib/*.js",
"lib/*.d.ts"
],
+ "system": {
+ "npmIgnore": [
+ "devDependencies"
+ ]
+ },
"author": "Project Jupyter",
"license": "BSD-3-Clause",
"bugs": { |
|
@blink1073 - Thanks for looking at this. I forgot to label this WIP. It's definitely not ready for scrutiny about documentation, whitespace, etc. I'm moving on to the notebook repo, which will test the design of this. When the basic system works, I'm coming back to go over the documentation, whitespace, etc. |
|
Ha, fair enough. |
|
Superseded by #4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on jupyter/jupyter-js-output-area#24