Minimal fix for #885: Animations don't work in IE11 #914
Conversation
arguments can't be properly polyfilled for iteration, so we use the args array (which gets emitted anyway)
|
To add: you still need to polyfill everything that IE11 doesn't support natively – it's just that it is now possible to run using the appropriate polyfills instead of not at all. |
|
I can't say when I'll have time to do this, but this is a good start for the problem - will see if I can get an automatic legacy build in for the polyfills at the same time... |
|
spent few hours debugging before I found this :/ could you please release new version @Rycochet ? |
|
@vojty I want to - but after merging this I started to update to the latest Typescript, and found quite a few potential bugs on the way - then ran out of time with it again - will try to finish the update and get things out this weekend! |
|
@vojty Pushed a new version today, planning to do some work on it over the weekend, so hopefully the other issues get fixed too! |
Minimal fix for #885: Animations don't work in IE11
Checklist
Animations do not work in ie11 #885
Yes, I agree
Please describe this Pull Request in as much detail as possible:
As stated in #885, there is a problem running animations in IE11. I traced it to the utility function
getValue, which tries to iteratearguments. This works in browsers with proper iterator support, but falls apart otherwise. The problem lies inargumentsbeing of typeobjectand notarrayso we can't really polyfill it (see babel/babel#1181).With this PR, the
argsvariable is iterated instead, since it is a proper array and can be polyfilled. Theargs-array is created and filled anywayvelocity/velocity.es5.js
Lines 150 to 152 in e238e87
People who contributed to this change:
Michael Wagner