8000 fix upload file bug by letungit90 · Pull Request #180 · jublo/codebird-php · GitHub
[go: up one dir, main page]
Skip to content

fix upload file bug #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2016
Merged

fix upload file bug #180

merged 4 commits into from
Aug 31, 2016

Conversation

letungit90
Copy link
Contributor

No description provided.

@mynetx mynetx merged commit 8cf0d58 into jublo:develop Aug 31, 2016
mynetx added a commit that referenced this pull request Aug 31, 2016
@mynetx
Add changelog entry for #180
bdcf2e2
@mynetx mynetx self-assigned this Aug 31, 2016
@mynetx mynetx added this to the 3.2 “Elsecar” milestone Aug 31, 2016
@mynetx
Copy link
Member
mynetx commented Aug 31, 2016

@letungit90 Thank you for contributing!

@letungit90
Copy link
Contributor Author

Thank you for merging.
In line 2575 you should change
(isset($headers['Location']) || isset($headers['Location'])
to
(isset($headers['Location']) || isset($headers['location'])

@mynetx
Copy link
Member
mynetx commented Sep 1, 2016

Thanks for noting!

mynetx added a commit that referenced this pull request Sep 1, 2016
@mynetx
Fix typo in _parseApiReplyPrefillHeaders
2048e51 
See #180.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mynetx mynetx

Labels
3 - Done Enhancement
Projects
None yet
Milestone
4.0 “Elsecar”
Development

Successfully merging this pull request may close these issues.
2 participants
@letungit90 @mynetx
0