8000 new Exception => new \Exception by freen · Pull Request #18 · jublo/codebird-php · GitHub
[go: up one dir, main page]
Skip to content

new Exception => new \Exception #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2013
Merged

new Exception => new \Exception #18

merged 1 commit into from
Apr 30, 2013

Conversation

freen
Copy link
Contributor
@freen freen commented Apr 30, 2013

Autoloading this library via Composer results in an Exception each time the Codebird library attempts to throw an Exception:

[30-Apr-2013 13:22:07 America/New_York] PHP Fatal error:  Class 'Codebird\Exception' not found in /Users/[...]/api/vendor/mynetx/codebird-php/src/codebird.php on line 453

This merge request would solve that issue.

@freen
new Exception => new \Exception
3731477 
Solves the exception thrown when attempting to throw these exceptions, & the library is namespaced.
@ZweiSteinSoft
Copy link
Contributor

Perfect find, thanks @freen!

ZweiSteinSoft pushed a commit that referenced this pull request Apr 30, 2013
@mynetx
Merge pull request #18 from freen/master
fffa914
@ZweiSteinSoft ZweiSteinSoft merged commit 3731477 into jublo:master Apr 30, 2013
@freen
Copy link
Contributor Author
freen commented Apr 30, 2013

:^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freen @ZweiSteinSoft
0