8000 Fix windows tests wip by jspanjers · Pull Request #2 · jspanjers/rubyzip · GitHub
[go: up one dir, main page]
Skip to content

Fix windows tests wip #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix windows tests wip #2

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6708449
`Entry#name_safe?` now allows Windows drive mappings.
hainesr May 30, 2021
fcee7cf
Preserve eol linefeed for text test data files
jspanjers Jun 6, 2021
a3c5eb5
Read/write test files in binay mode (for Windows compatibility)
jspanjers May 30, 2021
2e12df2
Prevent adding a newline to comments for generated test files on Windows
jspanjers Jun 3, 2021
8d549ee
Do not hardcode /tmp in entry_test
jspanjers Jun 4, 2021
60b529c
Fix FileSystem::ZipFileNameMapper#expand_path on Windows
jspanjers Jun 5, 2021
0872647
Prevent directory not empty error when running file_test on Windows
jspanjers Jun 4, 2021
6225fee
Make recover file permissions test better understandable
jspanjers Jun 4, 2021
71534ff
Disable recover file permissions test on Windows
jspanjers Jun 4, 2021
e37f99e
Fixup 71534ff
jspanjers Jun 6, 2021
d706d8b
REVERT ME: This disables a test fixed by #486
jspanjers Jun 4, 2021
d0206b9
Fixup d200619
jspanjers Jun 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup 71534ff
  • Loading branch information
@jspanjers
jspanjers committed Jun 6, 2021
commit e37f99eb25e5859853592c6ee360556f77e11d99
6 changes: 2 additions & 4 deletions test/file_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,8 @@ def test_add_stored
end

def test_recover_permissions_after_add_files_to_archive
if Zip::RUNNING_ON_WINDOWS
# Windows NT does not support granular permissions
return
end
# Windows NT does not support granular permissions
skip if Zip::RUNNING_ON_WINDOWS

src_zip = TEST_ZIP.zip_name
assert(::File.exist?(src_zip))
Expand Down
0