openapi: support client-generated id #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verdie-g
commented
Feb 23, 2024
verdie-g
commented
Feb 23, 2024
verdie-g
commented
Feb 23, 2024
verdie-g
commented
Feb 23, 2024
|
@bkoelman could you help with the those comments 👆 |
|
Tests are needed to cover:
for the three modes The easiest setup would be to have three resource types with different |
441ef62 to
5cabf90
Compare
verdie-g
commented
Feb 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## openapi #1475 +/- ##
========================================
Coverage 90.75% 90.75%
========================================
Files 390 390
Lines 12883 12883
Branches 2044 2044
========================================
Hits 11692 11692
Misses 776 776
Partials 415 415 ☔ View full report in Codecov by Sentry. |
bkoelman
requested changes
Feb 26, 2024
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdFakers.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdFakers.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdTests.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdTests.cs
Outdated
Show resolved
Hide resolved
test/OpenApiTests/ClientIdGenerationModes/ClientGeneratedIdTests.cs
Outdated
Show resolved
Hide resolved
bkoelman
requested changes
Feb 26, 2024
test/OpenApiEndToEndTests/ClientIdGenerationModes/ClientIdGenerationModesTests.cs
Outdated
Show resolved
Hide resolved
test/OpenApiEndToEndTests/ClientIdGenerationModes/ClientIdGenerationModesTests.cs
Outdated
Show resolved
Hide resolved
bkoelman
approved these changes
Feb 26, 2024
bf41287 to
66cf92f
Compare
66cf92f to
fccd8dd
Compare
fccd8dd to
54c401c
Compare
4 tasks
|
Thanks! I couldn't find the time to do the Kiota part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1054
QUALITY CHECKLIST