8000 Meta in linkages by hhware · Pull Request #559 · json-api/json-api · GitHub
[go: up one dir, main page]

Skip to content

Meta in linkages #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2015
Merged

Meta in linkages #559

merged 1 commit into from
Apr 30, 2015

Conversation

hhware
Copy link
Contributor
@hhware hhware commented Apr 18, 2015

Implements suggestion from #431 (comment). Please see #415 and #431 for more details.

I would like to request to consider this for 1.0.

@tkellen
Copy link
Member
tkellen commented Apr 20, 2015

👍 from me. @dgeb?

@@ -309,6 +309,8 @@ Resource linkage **MUST** be represented as one of the following:

A "linkage object" is an object that identifies an individual related resource.
It **MUST** contain `type` and `id` members.
A linkage object **MAY** include `"meta"` member to contain non-standard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an a after include and then I'm 👍

@hhware hhware force-pushed the i415-meta-in-linkages branch from 4f892e2 to f3e05b4 Compare April 25, 2015 21:23
@hhware
Copy link
Contributor Author
hhware commented Apr 25, 2015

Updated, thanks!

dgeb added a commit that referenced this pull request Apr 30, 2015
@dgeb dgeb merged commit 719407a into json-api:gh-pages Apr 30, 2015
@dgeb
Copy link
Member
dgeb commented Apr 30, 2015

Thanks @hhware!

@hhware hhware deleted the i415-meta-in-linkages branch April 30, 2015 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0