-
Notifications
You must be signed in to change notification settings - Fork 882
Make schema public and restore /schema
#1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
Decided to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
/schema
I have been testing this by way of improving Drupal's OpenAPI docs and noted errors from the Redocly CLI validator that the "dependencies" key is unknown. That's not quite correct because it's deprecated, so they're a little over-strict, but we should not ship a schema with deprecated properties. I also upped the validation level for It would be really amazing to move this forward. I think this schema is stable, a huge improvement on what was previously on |
@dgeb please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradjones1 this appears to be a solid start, but one that I'd like to give the community the chance to weigh in on before it is finalized. For this reason, I have left the schema a "draft" until it has been publicly reviewed and commented upon. I'll add a blurb to the front page soon.
@@ -1,15 +1,11 @@ | |||
{ | |||
"$schema": "https://json-schema.org/draft/2020-12/schema", | |||
"$id": "https://jsonapi.org/schemas/spec/v1.0/draft", | |||
"$comment": "The $id URI should be modified before releasing. This URI does not need to be network addressable. It is an ID only.", | |||
"$id": "https://jsonapi.org/schemas/1.0/schema.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"$id": "https://jsonapi.org/schemas/spec/v1.0/draft",
"$comment": "The $id URI should be modified before releasing. This URI does not need to be network addressable. It is an ID only.",
The schema should remain a draft until it has been publicly reviewed.
Anyone feel like finishing this PR? <3 |
we really need this to be merged |
would you mind resolving the review comment please? |
Fixes #1749