Added "allow" attribute for links to restrict access #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR relates to the discussion in #745 If access to a resource is limited by a permission system, the HTTP header that can be sent along with the resource is "Allow: GET, PATCH, DELETE". For included resources, the link attribute should be able to list the allowed methods the same way: ``` "links": { "related": { "href": "http://example.com/articles/1/comments", "allow": ["GET", "PATCH", "DELETE"] } } ``` to be as close as possible to the HTTP header. Only "Allow" should lower-case to be in line with all other keys in the JSON payload.
|
Thanks a lot for your proposal. Looking at v1.1 this could be addressed using an extension as well. Doing so would be better in my perspective:
|
|
HTTP methods discovery should be done by HEAD or OPTIONS methods |
|
@bednic That's not practical for all the links in the sent JSON response because they can have different allowed methods, e.g. GET for all resources, POST/DELETE only for adding/removing products into/from the basket. Doing OPTIONS requests for each link would generate a lot of request which should be avoided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to the discussion in #745
If access to a 8000 resource is limited by a permission system, the HTTP header that can be sent along with the resource is "Allow: GET, PATCH, DELETE". For included resources, the link attribute should be able to list the allowed methods the same way:
to be as close as possible to the HTTP header. Only "Allow" should lower-case to be in line with all other keys in the JSON payload.