Added option to use longnames in navigation to default template #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,7 +300,13 @@ function buildMemberNav(items, itemHeading, itemsSeen, linktoFn) { | |||
| itemsNav += '<li>' + linktoFn('', item.name) + '</li>'; | |||
| } | |||
| else if ( !hasOwnProp.call(itemsSeen, item.longname) ) { | |||
| itemsNav += '<li>' + linktoFn(item.longname, item.name.replace(/^module:/, '')) + '</li>'; | |||
| var displayName; | |||
| if (env.conf.templates.useLongnameInNav) | |||
There was a problem hiding this comment.
Should be env.conf.templates.default.useLongnameInNav.
Also, please use braces in the if/else statement for consistency with the rest of the file.
|
Sorry for the delay in reviewing this. I'll merge as soon as you've addressed my comments. |
|
Updated the pull request, addressing your comments. Thanks for reviewing. |
hegemonic
added a commit
that referenced
this pull request
Aug 13, 2015
Added option to use longnames in navigation to default template
|
Merged to master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the names of the symbols themselves are shown in the navigation. However this is confusing and results in ambiguous names in larger projects. So I'd like to add an option to show the full namepath instead.