minor symfony#52521 [AssetMapper] Improving exception if a vendor asset's path is not mapped (weaverryan)

nicolas-grekas · nicolas-grekas · commit 18d866c99e3f · 2023-11-10T08:34:09.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [AssetMapper] Improving exception if a vendor asset's path is not mapped | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix symfony#52513 | License | MIT <img width="931" alt="Screenshot 2023-11-09 at 1 33 49 PM" src="https://github.com/symfony/symfony/assets/121003/71259583-97fa-40b6-9aab-ead80cf2d316"> It's a bit long - but this should be a RARE error, when users are messing around with asset mapper paths. So giving them more info is better. /cc `@evertharmeling` :) Commits ------- 4d66462 [AssetMapper] Improving exception if a vendor asset's path is not mapped
diff --git a/src/Symfony/Component/AssetMapper/ImportMap/ImportMapGenerator.php b/src/Symfony/Component/AssetMapper/ImportMap/ImportMapGenerator.php
@@ -241,7 +241,11 @@ private function findEagerImports(MappedAsset $asset): array
     private function createMissingImportMapAssetException(ImportMapEntry $entry): \InvalidArgumentException
     {
         if ($entry->isRemotePackage()) {
-            throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));
+            if (!is_file($entry->path)) {
+                throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));
+            }
+
+            throw new LogicException(sprintf('The "%s" vendor file exists locally (%s), but cannot be found in any asset map paths. Be sure the assets vendor directory is an asset mapper path.', $entry->importName, $entry->path));
         }
 
         throw new LogicException(sprintf('The asset "%s" cannot be found in any asset map paths.', $entry->path));

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,11 @@ private function findEagerImports(MappedAsset $asset): array`
`241`	`241`	`private function createMissingImportMapAssetException(ImportMapEntry $entry): \InvalidArgumentException`
`242`	`242`	`{`
`243`	`243`	`if ($entry->isRemotePackage()) {`
`244`		`- throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));`
	`244`	`+ if (!is_file($entry->path)) {`
	`245`	`+ throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));`
	`246`	`+ }`
	`247`	`+`
	`248`	`+ throw new LogicException(sprintf('The "%s" vendor file exists locally (%s), but cannot be found in any asset map paths. Be sure the assets vendor directory is an asset mapper path.', $entry->importName, $entry->path));`
`245`	`249`	`}`
`246`	`250`
`247`	`251`	`throw new LogicException(sprintf('The asset "%s" cannot be found in any asset map paths.', $entry->path));`